Fix Grafana's data source config for pgsql#666
Conversation
marcleblanc2
force-pushed
the
marc/fix-pgsql-data-source-for-grafana
branch
from
2dc30b5 to
6329279
Compare
marcleblanc2
force-pushed
the
marc/fix-pgsql-data-source-for-grafana
branch
from
6329279 to
22aaa60
Compare
marcleblanc2
changed the title
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
@marcleblanc2 can you add a little more context here? I'm not sure I see the difference aside from the removal of editable
Yes, adding This would be a one-line diff, but I also sorted the config keys in alphabetical order in the same commit |
|
I see. I know it's tempting to just "sort", but more often than not it's not really needed and makes reviewing what should be a simple change harder. |
### Checklist - [x] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan Tested on self-hosted instance <!-- As part of SOC2/GN-104 and SOC2/GN-105 requirements, all pull requests are REQUIRED to provide a "test plan". A test plan is a loose explanation of what you have done or implemented to test this, as outlined in our Testing principles and guidelines: https://docs.sourcegraph.com/dev/background-information/testing_principles Write your test plan here after the "Test plan" header. -->
2 participants
For Self-hosted Analytics project
Checklist
Test plan
Tested on self-hosted instance